diff options
| author | Fyodor <xarabonradarx@gmail.com> | 2013-04-23 17:07:49 +0400 |
|---|---|---|
| committer | Fyodor <xarabonradarx@gmail.com> | 2013-04-23 17:07:49 +0400 |
| commit | 746a9992f0a842ded7a15cc5ce0afd0fa00f2ada (patch) | |
| tree | ddd76cb6734e812c60ea0eeef7d4c6d54b07ea61 /activerecord/test/cases | |
| parent | a56b150b6401cc3384d2be2db7530662047966e0 (diff) | |
| download | rails-746a9992f0a842ded7a15cc5ce0afd0fa00f2ada.tar.gz rails-746a9992f0a842ded7a15cc5ce0afd0fa00f2ada.tar.bz2 rails-746a9992f0a842ded7a15cc5ce0afd0fa00f2ada.zip | |
When empty options passed to having clause having_values was [nil] but should be empty.
Diffstat (limited to 'activerecord/test/cases')
| -rw-r--r-- | activerecord/test/cases/relations_test.rb | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb index 9008c2785e..cf6af4e8f4 100644 --- a/activerecord/test/cases/relations_test.rb +++ b/activerecord/test/cases/relations_test.rb @@ -1299,6 +1299,14 @@ class RelationTest < ActiveRecord::TestCase assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name) end + def test_doesnt_add_having_values_if_options_are_blank + scope = Post.having('') + assert_equal [], scope.having_values + + scope = Post.having([]) + assert_equal [], scope.having_values + end + def test_references_triggers_eager_loading scope = Post.includes(:comments) assert !scope.eager_loading? |