diff options
| author | Rafael França <rafaelmfranca@gmail.com> | 2017-06-26 17:25:45 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-26 17:25:45 -0400 |
| commit | 61cc630ac7e7f8554dc049a3e5a2509c00303ef8 (patch) | |
| tree | 96862a3875012ea78c792672cb0427eea7b1c148 /activerecord/test/cases | |
| parent | 7b841b61f57e0329be01e943b2ed157b0e11f4f8 (diff) | |
| parent | 5dafa72935fbb0656f814f26f94e46f545890214 (diff) | |
| download | rails-61cc630ac7e7f8554dc049a3e5a2509c00303ef8.tar.gz rails-61cc630ac7e7f8554dc049a3e5a2509c00303ef8.tar.bz2 rails-61cc630ac7e7f8554dc049a3e5a2509c00303ef8.zip | |
Merge pull request #29571 from kamipo/fix_extracting_references_via_order_values
Fix extracting `references` via `order_values` to respect quoting
Diffstat (limited to 'activerecord/test/cases')
| -rw-r--r-- | activerecord/test/cases/relations_test.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb index 86f3b0b962..dc81f13fe9 100644 --- a/activerecord/test/cases/relations_test.rb +++ b/activerecord/test/cases/relations_test.rb @@ -1717,6 +1717,9 @@ class RelationTest < ActiveRecord::TestCase scope = Post.order("comments.body") assert_equal ["comments"], scope.references_values + scope = Post.order("#{Comment.quoted_table_name}.#{Comment.quoted_primary_key}") + assert_equal ["comments"], scope.references_values + scope = Post.order("comments.body", "yaks.body") assert_equal ["comments", "yaks"], scope.references_values @@ -1735,6 +1738,9 @@ class RelationTest < ActiveRecord::TestCase scope = Post.reorder("comments.body") assert_equal %w(comments), scope.references_values + scope = Post.reorder("#{Comment.quoted_table_name}.#{Comment.quoted_primary_key}") + assert_equal ["comments"], scope.references_values + scope = Post.reorder("comments.body", "yaks.body") assert_equal %w(comments yaks), scope.references_values |