aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases
diff options
context:
space:
mode:
authorclaudiob <claudiob@gmail.com>2015-09-13 16:01:45 -0700
committerclaudiob <claudiob@gmail.com>2015-09-13 16:24:14 -0700
commit45ccc462137a57944ad0b1049d5624fe4af2b923 (patch)
treeaca7e51baadc11a09949be2e518dd86bd862fee4 /activerecord/test/cases
parentfecf9d729a81c6c08fef92936e659cdfcf340be5 (diff)
downloadrails-45ccc462137a57944ad0b1049d5624fe4af2b923.tar.gz
rails-45ccc462137a57944ad0b1049d5624fe4af2b923.tar.bz2
rails-45ccc462137a57944ad0b1049d5624fe4af2b923.zip
Remove AS methods that are never invoked
Fixes #21122 - does not change any current behavior; simply reflects the fact that two conditions of the if/else statement are never reached. The reason is #17227 which adds a default terminator to AS::Callbacks. Therefore, even callback chains that do not define a terminator now have a terminator, and `chain_config.key?(:terminator)` is always true. Of course, if no terminator was defined, then we want this new default terminator not to do anything special. What the terminator actually does (or should do) is discussed in #21218 but the simple fact that a default terminator exists makes this current PR valid. *Note* that the conditional/simple methods have not been removed in AS::Conditionals::Filter::After because of `:skip_after_callbacks_if_terminated` which lets a user decide **not** to skip after callbacks even if the chain was terminated.
Diffstat (limited to 'activerecord/test/cases')
0 files changed, 0 insertions, 0 deletions