aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/transaction_callbacks_test.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2015-07-24 17:22:22 -0600
committerSean Griffin <sean@thoughtbot.com>2015-07-24 17:22:22 -0600
commit12e5cb5db30f27bab1c44ebff1b3446336305603 (patch)
tree1ac63638dfd9c0f5de8b6bc8db9bc8f99e3d9b8c /activerecord/test/cases/transaction_callbacks_test.rb
parentd937a1175f10586b892842348c1d6ecaa47aad2e (diff)
downloadrails-12e5cb5db30f27bab1c44ebff1b3446336305603.tar.gz
rails-12e5cb5db30f27bab1c44ebff1b3446336305603.tar.bz2
rails-12e5cb5db30f27bab1c44ebff1b3446336305603.zip
Replace the giant comment in routes.rb with a link to the guides
This comment not only serves no purpose, but in my experience is actively detrimental to new developers getting started with Rails. Expereinced developers just end up deleting this comment, and are annoyed that they had to take this step. I also spend a lot of time mentoring brand new developers, and a consistent theme I've seen is that this comment just ends up intimidating them, and making them think it's dangerous to edit this file. One of my students just said this (due to the number of comments which even new developers don't actually read, they just see it as a sign that this thing is "dangerous"). > I don't edit any file that Rails generates for me, until my instructor > says that it's OK to do so. Realistically, this comment adds 0 value. We have very good documentation, which we can just link to instead. If someone is truly new enough to benefit from this info, they presumably just ran `gem install rails`, and have an internet connection that they can use to read the routing guide. The choice of language here was very specific. I chose "the DSL available" over "what is possible", because a consistent theme I've noticed among my students is that they aren't aware that this is actually a Ruby file, and can write any Ruby code here that they want. This file is not the only offender, but is by far the biggest point of pain that I've seen, and felt it was a good spot to open this discussion.
Diffstat (limited to 'activerecord/test/cases/transaction_callbacks_test.rb')
0 files changed, 0 insertions, 0 deletions