diff options
author | utilum <oz@utilum.com> | 2018-07-10 06:48:37 +0200 |
---|---|---|
committer | utilum <oz@utilum.com> | 2018-07-10 08:29:56 +0200 |
commit | f7bfb3db282f8333adb469b6d223b58523428d7d (patch) | |
tree | e8d50aab54d0b2bf2c06cac0d43613696c174163 /activerecord/test/cases/tasks/mysql_rake_test.rb | |
parent | d41ec8180d3df391e5fc0189f499d8689ca27e03 (diff) | |
download | rails-f7bfb3db282f8333adb469b6d223b58523428d7d.tar.gz rails-f7bfb3db282f8333adb469b6d223b58523428d7d.tar.bz2 rails-f7bfb3db282f8333adb469b6d223b58523428d7d.zip |
Replace shallow mocks with Ruby classes
While preparing this I realised that some stubbed returns values
serve no purpose, so this patch drops those as well.
Step 3 in #33162
Diffstat (limited to 'activerecord/test/cases/tasks/mysql_rake_test.rb')
-rw-r--r-- | activerecord/test/cases/tasks/mysql_rake_test.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/activerecord/test/cases/tasks/mysql_rake_test.rb b/activerecord/test/cases/tasks/mysql_rake_test.rb index ddbff81e72..ff2d66b17e 100644 --- a/activerecord/test/cases/tasks/mysql_rake_test.rb +++ b/activerecord/test/cases/tasks/mysql_rake_test.rb @@ -7,7 +7,7 @@ if current_adapter?(:Mysql2Adapter) module ActiveRecord class MysqlDBCreateTest < ActiveRecord::TestCase def setup - @connection = stub(create_database: true) + @connection = Class.new { def create_database(*); end }.new @configuration = { "adapter" => "mysql2", "database" => "my-app-db" @@ -96,7 +96,7 @@ if current_adapter?(:Mysql2Adapter) end def test_raises_error - assert_raises(Mysql2::Error) do + assert_raises(Mysql2::Error, "Invalid permissions") do ActiveRecord::Tasks::DatabaseTasks.create @configuration end end @@ -104,7 +104,7 @@ if current_adapter?(:Mysql2Adapter) class MySQLDBDropTest < ActiveRecord::TestCase def setup - @connection = stub(drop_database: true) + @connection = Class.new { def drop_database(name); true end }.new @configuration = { "adapter" => "mysql2", "database" => "my-app-db" @@ -142,7 +142,7 @@ if current_adapter?(:Mysql2Adapter) class MySQLPurgeTest < ActiveRecord::TestCase def setup - @connection = stub(recreate_database: true) + @connection = Class.new { def recreate_database(*); end }.new @configuration = { "adapter" => "mysql2", "database" => "test-db" @@ -176,7 +176,7 @@ if current_adapter?(:Mysql2Adapter) class MysqlDBCharsetTest < ActiveRecord::TestCase def setup - @connection = stub(create_database: true) + @connection = Class.new { def charset; end }.new @configuration = { "adapter" => "mysql2", "database" => "my-app-db" @@ -193,7 +193,7 @@ if current_adapter?(:Mysql2Adapter) class MysqlDBCollationTest < ActiveRecord::TestCase def setup - @connection = stub(create_database: true) + @connection = Class.new { def collation; end }.new @configuration = { "adapter" => "mysql2", "database" => "my-app-db" |