diff options
author | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2018-09-07 21:54:23 +0900 |
---|---|---|
committer | yuuji.yaginuma <yuuji.yaginuma@gmail.com> | 2018-12-18 08:09:16 +0900 |
commit | caa3cc8868206f8109e0d633efb09d31e94ef635 (patch) | |
tree | 88a50102350a8c171ec02891691720ebcb992124 /activerecord/test/cases/scoping/default_scoping_test.rb | |
parent | d57841b5c453370598f00dccd68000ae18c9ef58 (diff) | |
download | rails-caa3cc8868206f8109e0d633efb09d31e94ef635.tar.gz rails-caa3cc8868206f8109e0d633efb09d31e94ef635.tar.bz2 rails-caa3cc8868206f8109e0d633efb09d31e94ef635.zip |
Do not add parent directory to file system monitoring
`EventedFileUpdateChecker` will search the parent directory if the
specified directory does not exist.
Since `test/mailers/previews` is included in the watch target by default,
if there is no test directory (e.g. using `rspec`), the Rails root directory
will be included in the watch target.
```
$ rails new app
$ cd app
$ ./bin/rails r "p Rails.application.reloaders.last.send(:directories_to_watch).include?(Rails.root)"
false
$ rm -rf test
$ ./bin/rails r "p Rails.application.reloaders.last.send(:directories_to_watch).include?(Rails.root)"
true
```
This causes `node_modules` to be included in watch target. Adding parent
directories to watch target may include unexpected directories.
In order to avoid this, fixed that parents of nonexistent directories are
not added to the watch targets, instead checking that the directory
exists when checking changes.
Related to #32700.
[Matthew Draper & Yuji Yaginuma]
Diffstat (limited to 'activerecord/test/cases/scoping/default_scoping_test.rb')
0 files changed, 0 insertions, 0 deletions