diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2017-06-06 11:56:12 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-06-07 11:11:08 +0900 |
| commit | 9b8c7796a9c2048208aa843ad3dc477dffa8bdee (patch) | |
| tree | 1ab85743b084a1f315396e80025be467654499a9 /activerecord/test/cases/schema_dumper_test.rb | |
| parent | 2b96d5822bfe407be7589e293f3265c0c7a6726c (diff) | |
| download | rails-9b8c7796a9c2048208aa843ad3dc477dffa8bdee.tar.gz rails-9b8c7796a9c2048208aa843ad3dc477dffa8bdee.tar.bz2 rails-9b8c7796a9c2048208aa843ad3dc477dffa8bdee.zip | |
Avoid overwriting the methods of `AttributeMethods::PrimaryKey`
Currently the methods of `AttributeMethods::PrimaryKey` are overwritten
by `define_attribute_methods`. It will be broken if a table that
customized primary key has non primary key id column.
It should not be overwritten if a table has any primary key.
Fixes #29350.
Diffstat (limited to 'activerecord/test/cases/schema_dumper_test.rb')
| -rw-r--r-- | activerecord/test/cases/schema_dumper_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/test/cases/schema_dumper_test.rb b/activerecord/test/cases/schema_dumper_test.rb index 417c6f4832..b5386ba801 100644 --- a/activerecord/test/cases/schema_dumper_test.rb +++ b/activerecord/test/cases/schema_dumper_test.rb @@ -320,7 +320,7 @@ class SchemaDumperTest < ActiveRecord::TestCase def test_schema_dump_keeps_id_false_when_id_is_false_and_unique_not_null_column_added output = standard_dump - assert_match %r{create_table "subscribers", id: false}, output + assert_match %r{create_table "string_key_objects", id: false}, output end if ActiveRecord::Base.connection.supports_foreign_keys? |