diff options
author | Kevin Cheng <Kache@users.noreply.github.com> | 2016-01-29 17:44:04 -0500 |
---|---|---|
committer | Gannon McGibbon <gannon.mcgibbon@shopify.com> | 2018-09-18 16:40:10 -0400 |
commit | 16510d609c601aa7d466809f3073ec3313e08937 (patch) | |
tree | a7f1ccbc273008772d6611d9f882acb853aa4f8a /activerecord/test/cases/result_test.rb | |
parent | e925cb4d856088a815bf4a0cf27518d01bb4029d (diff) | |
download | rails-16510d609c601aa7d466809f3073ec3313e08937.tar.gz rails-16510d609c601aa7d466809f3073ec3313e08937.tar.bz2 rails-16510d609c601aa7d466809f3073ec3313e08937.zip |
Deprecate ActiveRecord::Result#to_hash in favor of #to_a
method returns an array of hashes, not a hash
e.g. Hash.try_convert(result) calls #to_hash and raises a TypeError
[Gannon McGibbon + Kevin Cheng]
Diffstat (limited to 'activerecord/test/cases/result_test.rb')
-rw-r--r-- | activerecord/test/cases/result_test.rb | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/activerecord/test/cases/result_test.rb b/activerecord/test/cases/result_test.rb index 68fcafb682..825aee2423 100644 --- a/activerecord/test/cases/result_test.rb +++ b/activerecord/test/cases/result_test.rb @@ -21,12 +21,22 @@ module ActiveRecord assert_equal 3, result.length end - test "to_hash returns row_hashes" do + test "to_a returns row_hashes" do assert_equal [ { "col_1" => "row 1 col 1", "col_2" => "row 1 col 2" }, { "col_1" => "row 2 col 1", "col_2" => "row 2 col 2" }, { "col_1" => "row 3 col 1", "col_2" => "row 3 col 2" }, - ], result.to_hash + ], result.to_a + end + + test "to_hash (deprecated) returns row_hashes" do + assert_deprecated do + assert_equal [ + { "col_1" => "row 1 col 1", "col_2" => "row 1 col 2" }, + { "col_1" => "row 2 col 1", "col_2" => "row 2 col 2" }, + { "col_1" => "row 3 col 1", "col_2" => "row 3 col 2" }, + ], result.to_hash + end end test "first returns first row as a hash" do |