aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/relations_test.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2015-10-15 08:09:18 -0700
committerSean Griffin <sean@seantheprogrammer.com>2015-10-15 08:09:18 -0700
commitde92b06bca9e744525452dd83e13a784bcfb9d3e (patch)
tree4348dfc3a81f4843219259e6326b510ad0bd8f71 /activerecord/test/cases/relations_test.rb
parentb6cf69ebcbf7372c61d38aa33baa7d0f4224679b (diff)
parentb901a49473817339e892f6c237a365a361b0b2d7 (diff)
downloadrails-de92b06bca9e744525452dd83e13a784bcfb9d3e.tar.gz
rails-de92b06bca9e744525452dd83e13a784bcfb9d3e.tar.bz2
rails-de92b06bca9e744525452dd83e13a784bcfb9d3e.zip
Merge pull request #21964 from Drenmi/enhancement/update-deprecation-message
Better deprecation warning for `ActiveRecord::Relation#update`
Diffstat (limited to 'activerecord/test/cases/relations_test.rb')
-rw-r--r--activerecord/test/cases/relations_test.rb7
1 files changed, 7 insertions, 0 deletions
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb
index 8256762f96..7521f0573a 100644
--- a/activerecord/test/cases/relations_test.rb
+++ b/activerecord/test/cases/relations_test.rb
@@ -1541,6 +1541,13 @@ class RelationTest < ActiveRecord::TestCase
assert_equal 'David', topic2.reload.author_name
end
+ def test_update_on_relation_passing_active_record_object_is_deprecated
+ topic = Topic.create!(title: 'Foo', author_name: nil)
+ assert_deprecated(/update/) do
+ Topic.where(id: topic.id).update(topic, title: 'Bar')
+ end
+ end
+
def test_distinct
tag1 = Tag.create(:name => 'Foo')
tag2 = Tag.create(:name => 'Foo')