diff options
| author | Leandro Facchinetti <git@leafac.com> | 2014-05-12 12:06:35 -0300 |
|---|---|---|
| committer | Leandro Facchinetti <git@leafac.com> | 2014-05-16 00:39:02 -0300 |
| commit | 5866437eefa19a38010c6045b9015b9508dd8a0d (patch) | |
| tree | 6d407fb8b452a91f77fef23f5bfe6784ae4491b5 /activerecord/test/cases/relations_test.rb | |
| parent | f25f5336ee07cc42207dc036d1a962b500969d10 (diff) | |
| download | rails-5866437eefa19a38010c6045b9015b9508dd8a0d.tar.gz rails-5866437eefa19a38010c6045b9015b9508dd8a0d.tar.bz2 rails-5866437eefa19a38010c6045b9015b9508dd8a0d.zip | |
Fix `Relation#delete_all` inconsistency
When relation scopes include one of `uniq`, `group`, `having` or
`offset`, the generated query ignores them and that causes unintended
records to be deleted. This solves the issue by restricting the deletion
when those scopes are present.
rails/rails#11985
Diffstat (limited to 'activerecord/test/cases/relations_test.rb')
| -rw-r--r-- | activerecord/test/cases/relations_test.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb index 6a880c6680..6ab1bd8c8b 100644 --- a/activerecord/test/cases/relations_test.rb +++ b/activerecord/test/cases/relations_test.rb @@ -831,8 +831,12 @@ class RelationTest < ActiveRecord::TestCase assert davids.loaded? end - def test_delete_all_limit_error + def test_delete_all_with_unpermitted_relation_raises_error assert_raises(ActiveRecord::ActiveRecordError) { Author.limit(10).delete_all } + assert_raises(ActiveRecord::ActiveRecordError) { Author.uniq.delete_all } + assert_raises(ActiveRecord::ActiveRecordError) { Author.group(:name).delete_all } + assert_raises(ActiveRecord::ActiveRecordError) { Author.having('SUM(id) < 3').delete_all } + assert_raises(ActiveRecord::ActiveRecordError) { Author.offset(10).delete_all } end def test_select_with_aggregates |