diff options
| author | Dillon Welch <daw0328@gmail.com> | 2018-03-29 19:29:55 -0700 |
|---|---|---|
| committer | Dillon Welch <daw0328@gmail.com> | 2018-07-23 15:37:06 -0700 |
| commit | d108288c2f684233298f97f18ac00de0b016deaa (patch) | |
| tree | 0656fd6f20d662d854a3fc93e80dfbc0baec063d /activerecord/test/cases/relation_test.rb | |
| parent | a4398e412c042b297039cc216f6536b0c048bd9c (diff) | |
| download | rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.gz rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.bz2 rails-d108288c2f684233298f97f18ac00de0b016deaa.zip | |
Turn on performance based cops
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
Diffstat (limited to 'activerecord/test/cases/relation_test.rb')
| -rw-r--r-- | activerecord/test/cases/relation_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/test/cases/relation_test.rb b/activerecord/test/cases/relation_test.rb index fbeb617b29..3ca15640fd 100644 --- a/activerecord/test/cases/relation_test.rb +++ b/activerecord/test/cases/relation_test.rb @@ -187,7 +187,7 @@ module ActiveRecord end relation = Relation.new(klass) - relation.merge!(where: ["foo = ?", "bar"]) + relation.merge!(where: ["foo = ?", "bar"]) # rubocop:disable Performance/RedundantMerge assert_equal Relation::WhereClause.new(["foo = bar"]), relation.where_clause end |