aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/relation_test.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2015-01-19 15:17:43 -0700
committerSean Griffin <sean@thoughtbot.com>2015-01-19 15:19:43 -0700
commit04d1c3716b5bfa133a0b1ed937649a0829ac5f22 (patch)
tree99bf898cfe3e93eeb4a31e931d642c222bb75a0f /activerecord/test/cases/relation_test.rb
parent50a8cdf0e2cff604b0361a370afc8becf2579d94 (diff)
downloadrails-04d1c3716b5bfa133a0b1ed937649a0829ac5f22.tar.gz
rails-04d1c3716b5bfa133a0b1ed937649a0829ac5f22.tar.bz2
rails-04d1c3716b5bfa133a0b1ed937649a0829ac5f22.zip
Fix bind value copying from subqueried relations
With the old implementation, the bind values were created, and then we search the attributes for `Relation` objects, and merge them. This completely ignores the order that the actual `where` clause will use. If all non-relation where parameters are before the relations, it will work. However, if we query on both a relation and a value, with the value coming second, it breaks. The order of the hash should not affect the final query (especially since hashes being ordered is an implementation detail)
Diffstat (limited to 'activerecord/test/cases/relation_test.rb')
0 files changed, 0 insertions, 0 deletions