aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/query_cache_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-06-15 07:33:20 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-06-15 10:56:56 +0900
commit9276ebc773d3287a9fa8d1c6ce9e3a14ceeb8add (patch)
tree55e883cadef2d0c09c60a77a81ecedfc90e2d753 /activerecord/test/cases/query_cache_test.rb
parentf340490b98ac9f13f004b5db8863cb3ff6fb71f9 (diff)
downloadrails-9276ebc773d3287a9fa8d1c6ce9e3a14ceeb8add.tar.gz
rails-9276ebc773d3287a9fa8d1c6ce9e3a14ceeb8add.tar.bz2
rails-9276ebc773d3287a9fa8d1c6ce9e3a14ceeb8add.zip
Fix `Relation#exists?` queries with query cache
If a connection adapter overrides `select_*` methods, query caching will doesn't work. This patch changes `select_value` to `select_one` in `Relation#exists?` to ensure query caching. Fixes #29449.
Diffstat (limited to 'activerecord/test/cases/query_cache_test.rb')
-rw-r--r--activerecord/test/cases/query_cache_test.rb6
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/test/cases/query_cache_test.rb b/activerecord/test/cases/query_cache_test.rb
index 494663eb04..d75ec72b03 100644
--- a/activerecord/test/cases/query_cache_test.rb
+++ b/activerecord/test/cases/query_cache_test.rb
@@ -204,6 +204,12 @@ class QueryCacheTest < ActiveRecord::TestCase
end
end
+ def test_exists_queries_with_cache
+ Post.cache do
+ assert_queries(1) { Post.exists?; Post.exists? }
+ end
+ end
+
def test_query_cache_dups_results_correctly
Task.cache do
now = Time.now.utc