diff options
author | Seb Jacobs <me@sebjacobs.com> | 2014-07-01 23:56:20 +0100 |
---|---|---|
committer | Andrew White <andyw@pixeltrix.co.uk> | 2014-07-06 08:52:32 +0100 |
commit | e972d341209f64d1599e30a36b82eee2aa4cd553 (patch) | |
tree | fd2f14ff1b6afb5005739abee0e55d389e515368 /activerecord/test/cases/primary_keys_test.rb | |
parent | b974033790c4cec68750d95b4f9789033f7ac93c (diff) | |
download | rails-e972d341209f64d1599e30a36b82eee2aa4cd553.tar.gz rails-e972d341209f64d1599e30a36b82eee2aa4cd553.tar.bz2 rails-e972d341209f64d1599e30a36b82eee2aa4cd553.zip |
Generate shallow paths for all children of shallow resources.
Prior to this commit shallow resources would only generate paths for
non-direct children (with a nested depth greater than 1).
Take the following routes file.
resources :blogs do
resources :posts, shallow: true do
resources :comments do
resources :tags
end
end
end
This would generate shallow paths for `tags` nested under `posts`,
e.g `/posts/:id/tags/`, however it would not generate shallow paths
for `comments` nested under `posts`, e.g `/posts/:id/comments/new`.
This commit changes the behaviour of the route mapper so that it
generate paths for direct children of shallow resources, for example
if you take the previous routes file, this will now generate
shallow paths for `comments` nested under `posts`, .e.g
`posts/:id/comments/new`.
This was the behaviour in Rails `4.0.4` however this was broken in
@jcoglan's fix for another routes related issue[1].
This also fixes an issue[2] reported by @smdern.
[1] https://github.com/rails/rails/commit/d0e5963
[2] https://github.com/rails/rails/issues/15783
Diffstat (limited to 'activerecord/test/cases/primary_keys_test.rb')
0 files changed, 0 insertions, 0 deletions