aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/pooled_connections_test.rb
diff options
context:
space:
mode:
authorPiotr Sarnacki <drogus@gmail.com>2012-08-10 23:27:51 +0200
committerPiotr Sarnacki <drogus@gmail.com>2012-08-11 00:21:46 +0200
commit5b3bb61f3fb82c7300d4dac374fe7aeafff6bda0 (patch)
tree60409040a33687482d95b05f992f361f5dd40219 /activerecord/test/cases/pooled_connections_test.rb
parentf2557112a5d87fc815aa577583dbcd9774848d11 (diff)
downloadrails-5b3bb61f3fb82c7300d4dac374fe7aeafff6bda0.tar.gz
rails-5b3bb61f3fb82c7300d4dac374fe7aeafff6bda0.tar.bz2
rails-5b3bb61f3fb82c7300d4dac374fe7aeafff6bda0.zip
Fix handling SCRIPT_NAME from within mounted engine's
When you mount your application at a path, for example /myapp, server should set SCRIPT_NAME to /myapp. With such information, rails application knows that it's mounted at /myapp path and it should generate routes relative to that path. Before this patch, rails handled SCRIPT_NAME correctly only for regular apps, but it failed to do it for mounted engines. The solution was to hardcode default_url_options[:script_name], which is not the best answer - it will work only when application is mounted at a fixed path. This patch fixes the situation by respecting original value of SCRIPT_NAME when generating application's routes from engine and the other way round - when you generate engine's routes from application. This is done by using one of 2 pieces of information in env - current SCRIPT_NAME or SCRIPT_NAME for a corresponding router. This is because we have 2 cases to handle: - generating engine's route from application: in this situation SCRIPT_NAME is basically SCRIPT_NAME set by the server and it indicates the place where application is mounted, so we can just pass it as :original_script_name in url_options. :original_script_name is used because if we use :script_name, router will ignore generating prefix for engine - generating application's route from engine: in this situation we already lost information about the SCRIPT_NAME that server used. For example if application is mounted at /myapp and engine is mounted at /blog, at this point SCRIPT_NAME is equal /myapp/blog. Because of that we need to keep reference to /myapp SCRIPT_NAME by binding it to the current router. Later on we can extract it and use when generating url Please note that starting from now you *should not* use default_url_options[:script_name] explicitly if your server already passes correct SCRIPT_NAME to rack env. (closes #6933)
Diffstat (limited to 'activerecord/test/cases/pooled_connections_test.rb')
0 files changed, 0 insertions, 0 deletions