diff options
author | Eileen M. Uchitelle <eileencodes@users.noreply.github.com> | 2018-09-27 11:45:11 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-09-27 11:45:11 -0400 |
commit | cb6ea5148bffdc6266740e2e7bf30965f3060680 (patch) | |
tree | 0888353d1ebce507db0aa066dba47f4fa5f5c1ec /activerecord/test/cases/migration/compatibility_test.rb | |
parent | 8a0194f1514fc2374b18db909f78f733ba0857b9 (diff) | |
parent | bdd8d5898710e727c55b514804a221b6eddbda41 (diff) | |
download | rails-cb6ea5148bffdc6266740e2e7bf30965f3060680.tar.gz rails-cb6ea5148bffdc6266740e2e7bf30965f3060680.tar.bz2 rails-cb6ea5148bffdc6266740e2e7bf30965f3060680.zip |
Merge pull request #31604 from fatkodima/reverting-transaction
Fix `transaction` reverting for migrations
Diffstat (limited to 'activerecord/test/cases/migration/compatibility_test.rb')
-rw-r--r-- | activerecord/test/cases/migration/compatibility_test.rb | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/activerecord/test/cases/migration/compatibility_test.rb b/activerecord/test/cases/migration/compatibility_test.rb index 69a50674af..017ee7951e 100644 --- a/activerecord/test/cases/migration/compatibility_test.rb +++ b/activerecord/test/cases/migration/compatibility_test.rb @@ -127,6 +127,20 @@ module ActiveRecord assert_match(/LegacyMigration < ActiveRecord::Migration\[4\.2\]/, e.message) end + def test_legacy_migrations_not_raise_exception_on_reverting_transaction + migration = Class.new(ActiveRecord::Migration[5.2]) { + def change + transaction do + execute "select 1" + end + end + }.new + + assert_nothing_raised do + migration.migrate(:down) + end + end + if current_adapter?(:PostgreSQLAdapter) class Testing < ActiveRecord::Base end |