diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2017-11-13 13:24:28 -0700 |
|---|---|---|
| committer | Sean Griffin <sean@seantheprogrammer.com> | 2017-11-13 13:31:46 -0700 |
| commit | 68fe6b08ee72cc47263e0d2c9ff07f75c4b42761 (patch) | |
| tree | 2556c4cd3cfe8778e5d43bec8f4ca28a2a5db594 /activerecord/test/cases/json_serialization_test.rb | |
| parent | f49d59432a0b5b4a492fd8464c00edbb5b9a8b7e (diff) | |
| download | rails-68fe6b08ee72cc47263e0d2c9ff07f75c4b42761.tar.gz rails-68fe6b08ee72cc47263e0d2c9ff07f75c4b42761.tar.bz2 rails-68fe6b08ee72cc47263e0d2c9ff07f75c4b42761.zip | |
Properly cast input in `update_all`
The documentation claims that given values go through "normal AR type
casting and serialization", which to me implies
`serialize(cast(value))`, not just serialization. The docs were changed
to use this wording in #22492. The tests I cited in that PR (which is
the same test modified in this commit), is worded in a way that implies
it should be using `cast` as well.
It's possible that I originally meant "normal type casting" to imply
just the call to `serialize`, but given that `update_all(archived:
params['archived'])` seems to be pretty common, I'm inclined to make
this change as long as no tests are broken from it.
Diffstat (limited to 'activerecord/test/cases/json_serialization_test.rb')
0 files changed, 0 insertions, 0 deletions