aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/finder_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-06-04 18:39:18 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-02-26 21:20:39 +0900
commit84f4ab90dabbe23db0cd6f74078da6d341401d10 (patch)
treedbc6ee8a13c2206f22741227e802ff249d151f6a /activerecord/test/cases/finder_test.rb
parent228c6c07f1b5e786c72d9e30b2755d764f7a425d (diff)
downloadrails-84f4ab90dabbe23db0cd6f74078da6d341401d10.tar.gz
rails-84f4ab90dabbe23db0cd6f74078da6d341401d10.tar.bz2
rails-84f4ab90dabbe23db0cd6f74078da6d341401d10.zip
Fix `find_nth` with `limit_value`
If the `index` exceeds a `limit`, simply return an empty result without querying the database.
Diffstat (limited to 'activerecord/test/cases/finder_test.rb')
-rw-r--r--activerecord/test/cases/finder_test.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/activerecord/test/cases/finder_test.rb b/activerecord/test/cases/finder_test.rb
index deec669935..89d8a8bdca 100644
--- a/activerecord/test/cases/finder_test.rb
+++ b/activerecord/test/cases/finder_test.rb
@@ -497,7 +497,7 @@ class FinderTest < ActiveRecord::TestCase
assert_nil Topic.offset(5).second_to_last
#test with limit
- # assert_nil Topic.limit(1).second # TODO: currently failing
+ assert_nil Topic.limit(1).second
assert_nil Topic.limit(1).second_to_last
end
@@ -526,9 +526,9 @@ class FinderTest < ActiveRecord::TestCase
assert_nil Topic.offset(5).third_to_last
# test with limit
- # assert_nil Topic.limit(1).third # TODO: currently failing
+ assert_nil Topic.limit(1).third
assert_nil Topic.limit(1).third_to_last
- # assert_nil Topic.limit(2).third # TODO: currently failing
+ assert_nil Topic.limit(2).third
assert_nil Topic.limit(2).third_to_last
end