diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2018-10-05 03:07:12 +0900 |
---|---|---|
committer | Ryuta Kamizono <kamipo@gmail.com> | 2018-10-05 04:11:13 +0900 |
commit | 811be477786455d144819a5e9fbb7f9f54b8da69 (patch) | |
tree | 95ccdab553e3a368f554c0276fc9af517d896a0f /activerecord/test/cases/dirty_test.rb | |
parent | 5c7c3fe0d7059ba62e14bf6ac4ddfbdcabd905a6 (diff) | |
download | rails-811be477786455d144819a5e9fbb7f9f54b8da69.tar.gz rails-811be477786455d144819a5e9fbb7f9f54b8da69.tar.bz2 rails-811be477786455d144819a5e9fbb7f9f54b8da69.zip |
Use `assert_no_queries` not to ignore BEGIN/COMMIT queries
`test_update_does_not_run_sql_if_record_has_not_changed` would pass
without #18501 since `assert_queries` ignores BEGIN/COMMIT unless
`ignore_none: true` is given.
Since #32647, empty BEGIN/COMMIT is ommited. So we no longer need to use
`assert_queries(0)` to ignore BEGIN/COMMIT in the queries.
Diffstat (limited to 'activerecord/test/cases/dirty_test.rb')
-rw-r--r-- | activerecord/test/cases/dirty_test.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb index b1ebd20d6b..dfd74bfcb4 100644 --- a/activerecord/test/cases/dirty_test.rb +++ b/activerecord/test/cases/dirty_test.rb @@ -336,7 +336,7 @@ class DirtyTest < ActiveRecord::TestCase end with_partial_writes Pirate, true do - assert_queries(0) { 2.times { pirate.save! } } + assert_no_queries { 2.times { pirate.save! } } assert_equal old_updated_on, pirate.reload.updated_on assert_queries(1) { pirate.catchphrase = "bar"; pirate.save! } @@ -355,7 +355,7 @@ class DirtyTest < ActiveRecord::TestCase old_lock_version = person.lock_version with_partial_writes Person, true do - assert_queries(0) { 2.times { person.save! } } + assert_no_queries { 2.times { person.save! } } assert_equal old_lock_version, person.reload.lock_version assert_queries(1) { person.first_name = "bar"; person.save! } |