aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/dirty_test.rb
diff options
context:
space:
mode:
authorSean Griffin <sean@thoughtbot.com>2015-06-12 11:00:27 -0600
committerSean Griffin <sean@thoughtbot.com>2015-06-12 11:03:12 -0600
commit07b4078eb664dd45b1526a85358574ea8e669ce3 (patch)
tree27160010746fb8134ebb1262be0dd97605c05b8b /activerecord/test/cases/dirty_test.rb
parent8beb328befa53d74fe9c7942ddb188563bd4de33 (diff)
downloadrails-07b4078eb664dd45b1526a85358574ea8e669ce3.tar.gz
rails-07b4078eb664dd45b1526a85358574ea8e669ce3.tar.bz2
rails-07b4078eb664dd45b1526a85358574ea8e669ce3.zip
Don't crash when mutating attributes in a getter
If a getter has side effects on the DB, `changes_applied` will be called twice. The second time will try and remove the changed attributes cache, and will crash because it's already been unset. This also demonstrates that we shouldn't assume that calling getters won't change the value of `changed_attributes`, and we need to clear the cache if an attribute is modified. Fixes #20531.
Diffstat (limited to 'activerecord/test/cases/dirty_test.rb')
-rw-r--r--activerecord/test/cases/dirty_test.rb16
1 files changed, 16 insertions, 0 deletions
diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb
index 216f228142..f5aaf22e13 100644
--- a/activerecord/test/cases/dirty_test.rb
+++ b/activerecord/test/cases/dirty_test.rb
@@ -703,6 +703,22 @@ class DirtyTest < ActiveRecord::TestCase
assert pirate.catchphrase_changed?(from: "arrrr", to: "arrrr matey!")
end
+ test "getters with side effects are allowed" do
+ klass = Class.new(Pirate) do
+ def catchphrase
+ if super.blank?
+ update_attribute(:catchphrase, "arr") # what could possibly go wrong?
+ end
+ super
+ end
+ end
+
+ pirate = klass.create!(catchphrase: "lol")
+ pirate.update_attribute(:catchphrase, nil)
+
+ assert_equal "arr", pirate.catchphrase
+ end
+
private
def with_partial_writes(klass, on = true)
old = klass.partial_writes?