diff options
| author | Ben Woosley <ben.woosley@gmail.com> | 2013-07-20 17:56:06 -0700 |
|---|---|---|
| committer | Ben Woosley <ben.woosley@gmail.com> | 2013-08-12 02:37:39 -0700 |
| commit | cc368c3ab39bc376181d883c31877d9729fe3423 (patch) | |
| tree | 5ceb2c20df8a3ff92f23d77d7217af290f696c3a /activerecord/test/cases/connection_pool_test.rb | |
| parent | d35e900c0046126d901ae9a78ce33e28f6c97644 (diff) | |
| download | rails-cc368c3ab39bc376181d883c31877d9729fe3423.tar.gz rails-cc368c3ab39bc376181d883c31877d9729fe3423.tar.bz2 rails-cc368c3ab39bc376181d883c31877d9729fe3423.zip | |
Refactor NestedAttributesWithCallbacksTest for clarity
1) Use `assert` and `refute` where possible.
2) Separately include the setup, subject, and assertions in each test - don't hide the tested call in an assertion method.
3) Name things based on their role rather than incidental facts about them - e.g. `@bird[1]` -> `bird_to_destroy`. `bird2_deletion_attributes` -> `destroy_bird_attributes`.
4) Use more succinct naming where possible - e.g. `birds_with_callback` -> `birds_with_add`, `@pirate_with_two_birds` -> `@pirate`
Diffstat (limited to 'activerecord/test/cases/connection_pool_test.rb')
0 files changed, 0 insertions, 0 deletions