Automatic closure of connections in threads is deprecated. For example

the following code is deprecated:

Thread.new { Post.find(1) }.join

It should be changed to close the database connection at the end of
the thread:

Thread.new {
  Post.find(1)
  Post.connection.close
}.join

Only people who spawn threads in their application code need to worry
about this change.

1 files changed, 5 insertions, 26 deletions

diff --git a/activerecord/test/cases/connection_pool_test.rb b/activerecord/test/cases/connection_pool_test.rb
index 1550fa5530..d170a13b23 100644
--- a/activerecord/test/cases/connection_pool_test.rb
+++ b/activerecord/test/cases/connection_pool_test.rb
@@ -26,30 +26,6 @@ module ActiveRecord
         assert !@pool.active_connection?
       end
 
-      def test_clear_stale_cached_connections!
-        pool = ConnectionPool.new ActiveRecord::Base.connection_pool.spec
-
-        threads = [
-          Thread.new { pool.connection },
-          Thread.new { pool.connection }]
-
-        threads.map { |t| t.join }
-
-        pool.extend Module.new {
-          attr_accessor :checkins
-          def checkin conn
-            @checkins << conn
-            conn.object_id
-          end
-        }
-        pool.checkins = []
-
-        cleared_threads = pool.clear_stale_cached_connections!
-        assert((cleared_threads - threads.map { |x| x.object_id }).empty?,
-               "threads should have been removed")
-        assert_equal pool.checkins.length, threads.length
-      end
-
       def test_checkout_behaviour
         pool = ConnectionPool.new ActiveRecord::Base.connection_pool.spec
         connection = pool.connection
@@ -70,12 +46,15 @@ module ActiveRecord
             assert thread_ids.include?(t.object_id)
           end
 
-          pool.connection
+          assert_deprecated do
+            pool.connection
+          end
           threads.each do |t|
             thread_ids = pool.instance_variable_get(:@reserved_connections).keys
             assert !thread_ids.include?(t.object_id)
           end
-        end.join()
+          pool.connection.close
+        end.join
 
       end