diff options
| author | bogdanvlviv <bogdanvlviv@gmail.com> | 2018-10-05 14:36:13 +0300 |
|---|---|---|
| committer | bogdanvlviv <bogdanvlviv@gmail.com> | 2018-10-05 14:42:15 +0300 |
| commit | 7e7a6a351c4845d8d92238147450b22fe87627f9 (patch) | |
| tree | 0b92a2bd7721f46e8c78975dd0738810115d9c0c /activerecord/test/cases/connection_adapters | |
| parent | 1ceaf7db5013a233bdc671b3f46583c4c1189fe1 (diff) | |
| download | rails-7e7a6a351c4845d8d92238147450b22fe87627f9.tar.gz rails-7e7a6a351c4845d8d92238147450b22fe87627f9.tar.bz2 rails-7e7a6a351c4845d8d92238147450b22fe87627f9.zip | |
Exercise stringify of database configurations
Since #33968 we stringify keys of database configuration
This commit adds more assertions in order to ensure that and prevent any
regression in the future.
Currently, if remove `to_s` added in #33968 from `env_name.to_s` on the
line
(activerecord/lib/active_record/database_configurations.rb:107), there is
no test that would fail. One of the added assertions should emphasize why we need
this `to_s`.
Follow up #33968
Diffstat (limited to 'activerecord/test/cases/connection_adapters')
| -rw-r--r-- | activerecord/test/cases/connection_adapters/connection_handler_test.rb | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activerecord/test/cases/connection_adapters/connection_handler_test.rb b/activerecord/test/cases/connection_adapters/connection_handler_test.rb index 5e3447efde..51d0cc3d12 100644 --- a/activerecord/test/cases/connection_adapters/connection_handler_test.rb +++ b/activerecord/test/cases/connection_adapters/connection_handler_test.rb @@ -170,6 +170,11 @@ module ActiveRecord ActiveRecord::Base.configurations = config ActiveRecord::Base.configurations.configs_for.each do |db_config| assert_instance_of ActiveRecord::DatabaseConfigurations::HashConfig, db_config + assert_instance_of String, db_config.env_name + assert_instance_of String, db_config.spec_name + db_config.config.keys.each do |key| + assert_instance_of String, key + end end ensure ActiveRecord::Base.configurations = @prev_configs |