diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2017-05-29 09:02:45 +0900 |
---|---|---|
committer | Ryuta Kamizono <kamipo@gmail.com> | 2017-05-29 09:02:45 +0900 |
commit | 36417cf07790b645b3f3c0fde095d1059bcf0ea9 (patch) | |
tree | 1c4a75608971c9afba27e4653805f86628fdaea6 /activerecord/test/cases/calculations_test.rb | |
parent | acdf234a4cf28fdf20dcd49ac4013d84448d65b1 (diff) | |
download | rails-36417cf07790b645b3f3c0fde095d1059bcf0ea9.tar.gz rails-36417cf07790b645b3f3c0fde095d1059bcf0ea9.tar.bz2 rails-36417cf07790b645b3f3c0fde095d1059bcf0ea9.zip |
Deprecate passing arguments and block at the same time to `count` and `sum` in `ActiveRecord::Calculations`
`select`, `count`, and `sum` in `Relation` are also `Enumerable` method
that can be passed block. `select` with block already doesn't take
arguments since 4fc3366. This is follow up of that.
Diffstat (limited to 'activerecord/test/cases/calculations_test.rb')
-rw-r--r-- | activerecord/test/cases/calculations_test.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/activerecord/test/cases/calculations_test.rb b/activerecord/test/cases/calculations_test.rb index 3214d778d4..93f8ab18c2 100644 --- a/activerecord/test/cases/calculations_test.rb +++ b/activerecord/test/cases/calculations_test.rb @@ -809,4 +809,16 @@ class CalculationsTest < ActiveRecord::TestCase def test_group_by_attribute_with_custom_type assert_equal({ "proposed" => 2, "published" => 2 }, Book.group(:status).count) end + + def test_deprecate_count_with_block_and_column_name + assert_deprecated do + assert_equal 6, Account.count(:firm_id) { true } + end + end + + def test_deprecate_sum_with_block_and_column_name + assert_deprecated do + assert_equal 6, Account.sum(:firm_id) { 1 } + end + end end |