aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/boolean_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-03-29 18:21:56 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-03-30 04:18:25 +0900
commit2d12f800f1c6b0a2018346e0139301070273e46f (patch)
tree14e8071407f733ef9acef4cb67b1494b45d05fb0 /activerecord/test/cases/boolean_test.rb
parentda2c92377c7f36469e56dc25a4ac0604157ac778 (diff)
downloadrails-2d12f800f1c6b0a2018346e0139301070273e46f.tar.gz
rails-2d12f800f1c6b0a2018346e0139301070273e46f.tar.bz2
rails-2d12f800f1c6b0a2018346e0139301070273e46f.zip
Type cast falsy boolean symbols on boolean attribute as false
Before 34cc301, type casting by boolean attribute when querying is a no-op, so finding by truthy boolean string (i.e. `where(value: "true") # => value = 'true'`) didn't work as expected (matches it to FALSE in MySQL #32624). By type casting is ensured, a value on boolean attribute is always serialized to TRUE or FALSE. In PostgreSQL, `where(value: :false) # => value = 'false'` was a valid SQL, so 34cc301 is a regresson for PostgreSQL since all symbol values are serialized as TRUE. I'd say using `:false` is mostly a developer's mistake (user's input basically comes as a string), but `:false` on boolean attribute is serialized as TRUE is not a desirable behavior for anybody. This allows falsy boolean symbols as false, i.e. `klass.create(value: :false).value? # => false` and `where(value: :false) # => value = FALSE`. Fixes #35676.
Diffstat (limited to 'activerecord/test/cases/boolean_test.rb')
-rw-r--r--activerecord/test/cases/boolean_test.rb9
1 files changed, 9 insertions, 0 deletions
diff --git a/activerecord/test/cases/boolean_test.rb b/activerecord/test/cases/boolean_test.rb
index ab9f974e2c..18824004d2 100644
--- a/activerecord/test/cases/boolean_test.rb
+++ b/activerecord/test/cases/boolean_test.rb
@@ -40,4 +40,13 @@ class BooleanTest < ActiveRecord::TestCase
assert_equal b_false, Boolean.find_by(value: "false")
assert_equal b_true, Boolean.find_by(value: "true")
end
+
+ def test_find_by_falsy_boolean_symbol
+ ActiveModel::Type::Boolean::FALSE_VALUES.each do |value|
+ b_false = Boolean.create!(value: value)
+
+ assert_not_predicate b_false, :value?
+ assert_equal b_false, Boolean.find_by(id: b_false.id, value: value.to_s.to_sym)
+ end
+ end
end