Remove ActiveRecord::Base.to_a

On reflection, it seems like a bit of a weird method to have on
ActiveRecord::Base, and it shouldn't be needed most of the time anyway.

1 files changed, 3 insertions, 11 deletions

diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb
index 195597ace6..062f196a12 100644
--- a/activerecord/test/cases/base_test.rb
+++ b/activerecord/test/cases/base_test.rb
@@ -1635,9 +1635,9 @@ class BasicsTest < ActiveRecord::TestCase
   end
 
   def test_all
-    developers = Developer.to_a
-    assert_kind_of Array, developers
-    assert_equal Developer.to_a, developers
+    developers = Developer.all
+    assert_kind_of ActiveRecord::Relation, developers
+    assert_equal Developer.all, developers
   end
 
   def test_all_with_conditions
@@ -2032,12 +2032,4 @@ class BasicsTest < ActiveRecord::TestCase
     klass = Class.new(ActiveRecord::Base)
     assert_equal ['foo'], klass.all.merge!(select: 'foo').select_values
   end
-
-  test "Model.to_a returns an array" do
-    assert_equal Post.all.to_a, Post.to_a
-  end
-
-  test "Model.all returns a relation" do
-    assert Post.all.is_a?(ActiveRecord::Relation)
-  end
 end