diff options
| author | Yves Senn <yves.senn@garaio.com> | 2012-11-21 09:48:48 +0100 |
|---|---|---|
| committer | Yves Senn <yves.senn@garaio.com> | 2012-11-22 15:08:17 +0100 |
| commit | d397a38c0268e61295e23f617e9bf70d905ea610 (patch) | |
| tree | c40be8c2333aaba0928e41407e0fd2ac0442809c /activerecord/test/cases/associations | |
| parent | 4e00e8e91637e117f702ec277a5db1fd087cb347 (diff) | |
| download | rails-d397a38c0268e61295e23f617e9bf70d905ea610.tar.gz rails-d397a38c0268e61295e23f617e9bf70d905ea610.tar.bz2 rails-d397a38c0268e61295e23f617e9bf70d905ea610.zip | |
backport #8291, prevent mass assignment of polymorphic type with `build`
Closes #8265
Conflicts:
activerecord/CHANGELOG.md
activerecord/lib/active_record/associations/association.rb
Diffstat (limited to 'activerecord/test/cases/associations')
| -rw-r--r-- | activerecord/test/cases/associations/has_many_associations_test.rb | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/activerecord/test/cases/associations/has_many_associations_test.rb b/activerecord/test/cases/associations/has_many_associations_test.rb index c311bf70d2..b4788e0a3d 100644 --- a/activerecord/test/cases/associations/has_many_associations_test.rb +++ b/activerecord/test/cases/associations/has_many_associations_test.rb @@ -1704,6 +1704,14 @@ class HasManyAssociationsTest < ActiveRecord::TestCase assert_equal [tagging], post.taggings end + def test_build_with_polymotphic_has_many_does_not_allow_to_override_type_and_id + welcome = posts(:welcome) + tagging = welcome.taggings.build(:taggable_id => 99, :taggable_type => 'ShouldNotChange') + + assert_equal welcome.id, tagging.taggable_id + assert_equal 'Post', tagging.taggable_type + end + def test_dont_call_save_callbacks_twice_on_has_many firm = companies(:first_firm) contract = firm.contracts.create! |