aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2016-05-12 09:06:29 -0400
committerSean Griffin <sean@seantheprogrammer.com>2016-05-12 09:09:47 -0400
commit6007e584d824225e51f47ba0684d48ea3eb8f518 (patch)
treed75d636ca8c927b6c4502a6bd06725a04d0a2ad2 /activerecord/test/cases/associations
parent548c1d6e8b819ca4e02e6218b67107c580ee65f2 (diff)
downloadrails-6007e584d824225e51f47ba0684d48ea3eb8f518.tar.gz
rails-6007e584d824225e51f47ba0684d48ea3eb8f518.tar.bz2
rails-6007e584d824225e51f47ba0684d48ea3eb8f518.zip
Fix false positive mutation detection when JSON is used with serialize
When looking for mutation, we compare the serialized version of the value to the before_type_cast form. `Type::Serialized` was breaking this contract by passing the already serialized attribute to the subtype's mutation detection. This never manifested previously, as all mutable subtypes either didn't do anything in their `serialize` method, or had a way to detect double serialization (e.g. `is_a?(String)`). However, now that JSON types can handle string primitives, we need to avoid double serialization. Fixes #24993.
Diffstat (limited to 'activerecord/test/cases/associations')
0 files changed, 0 insertions, 0 deletions