aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-05-15 22:24:57 +0900
committerGitHub <noreply@github.com>2019-05-15 22:24:57 +0900
commit13d6aa3a7b70bca66c4abda7721329ad1863c24c (patch)
treef1ce8b480b853df1f32cd7ab5f7e92a0d62e1508 /activerecord/test/cases/associations
parenta2708473b150b30a00c80d64f57a8c4b41a32fcc (diff)
parentec6dfdc8d21031e07dd381853ff37fcc63f8bd86 (diff)
downloadrails-13d6aa3a7b70bca66c4abda7721329ad1863c24c.tar.gz
rails-13d6aa3a7b70bca66c4abda7721329ad1863c24c.tar.bz2
rails-13d6aa3a7b70bca66c4abda7721329ad1863c24c.zip
Merge pull request #36284 from kamipo/fix_eager_loading_with_string_joins
Fix eager loading associations with string joins not to raise NoMethodError
Diffstat (limited to 'activerecord/test/cases/associations')
-rw-r--r--activerecord/test/cases/associations/eager_test.rb11
1 files changed, 11 insertions, 0 deletions
diff --git a/activerecord/test/cases/associations/eager_test.rb b/activerecord/test/cases/associations/eager_test.rb
index 49bcb1d010..9ed25ca7c2 100644
--- a/activerecord/test/cases/associations/eager_test.rb
+++ b/activerecord/test/cases/associations/eager_test.rb
@@ -101,6 +101,17 @@ class EagerAssociationTest < ActiveRecord::TestCase
assert_equal [taggings(:normal_comment_rating)], rating.taggings_without_tag
end
+ def test_loading_association_with_string_joins
+ rating = Rating.first
+ assert_equal [taggings(:normal_comment_rating)], rating.taggings_with_no_tag
+
+ rating = Rating.preload(:taggings_with_no_tag).first
+ assert_equal [taggings(:normal_comment_rating)], rating.taggings_with_no_tag
+
+ rating = Rating.eager_load(:taggings_with_no_tag).first
+ assert_equal [taggings(:normal_comment_rating)], rating.taggings_with_no_tag
+ end
+
def test_loading_with_scope_including_joins
member = Member.first
assert_equal members(:groucho), member