aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/associations/join_model_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-11-07 00:01:53 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-11-13 06:19:28 +0900
commit0ec967aa6655d62c92f72acb8d556a5b3f70762d (patch)
tree100e287492d9ebb44b47f9b6cec7aaca72209774 /activerecord/test/cases/associations/join_model_test.rb
parentee7556cb08382f311bd40eec0e377aaa878c42e8 (diff)
downloadrails-0ec967aa6655d62c92f72acb8d556a5b3f70762d.tar.gz
rails-0ec967aa6655d62c92f72acb8d556a5b3f70762d.tar.bz2
rails-0ec967aa6655d62c92f72acb8d556a5b3f70762d.zip
Respect new records for `CollectionProxy#uniq`
Currently if `CollectionProxy` has more than one new record, `CollectionProxy#uniq` result is incorrect. And `CollectionProxy#uniq` was aliased to `distinct` in a1bb6c8b06db. But the `uniq` method and the `SELECT DISTINCT` method are different methods. The doc in `CollectionProxy` is for the `SELECT DISTINCT` method, not for the `uniq` method. Therefore, reverting the alias in `CollectionProxy` to fix the inconsistency and to have the both methods.
Diffstat (limited to 'activerecord/test/cases/associations/join_model_test.rb')
-rw-r--r--activerecord/test/cases/associations/join_model_test.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/test/cases/associations/join_model_test.rb b/activerecord/test/cases/associations/join_model_test.rb
index 15446c6dc7..a4345f3857 100644
--- a/activerecord/test/cases/associations/join_model_test.rb
+++ b/activerecord/test/cases/associations/join_model_test.rb
@@ -413,7 +413,7 @@ class AssociationsJoinModelTest < ActiveRecord::TestCase
author = Author.includes(:taggings).find authors(:david).id
expected_taggings = taggings(:welcome_general, :thinking_general)
assert_no_queries do
- assert_equal expected_taggings, author.taggings.distinct.sort_by(&:id)
+ assert_equal expected_taggings, author.taggings.uniq.sort_by(&:id)
end
end