diff options
| author | Sean Griffin <sean@thoughtbot.com> | 2014-06-15 09:19:54 -0600 |
|---|---|---|
| committer | Sean Griffin <sean@thoughtbot.com> | 2014-06-26 07:24:34 -0600 |
| commit | d730e374ca99a60b08c75aab7b0ed8a846a34924 (patch) | |
| tree | 179a789fd65ddc4c157f6bb088002a465755e6a8 /activerecord/test/cases/associations/belongs_to_associations_test.rb | |
| parent | e8003c7274c4049f409740b587e4e9e1f3df37f7 (diff) | |
| download | rails-d730e374ca99a60b08c75aab7b0ed8a846a34924.tar.gz rails-d730e374ca99a60b08c75aab7b0ed8a846a34924.tar.bz2 rails-d730e374ca99a60b08c75aab7b0ed8a846a34924.zip | |
Deprecate automatic counter caches on has_many :through
Reliant on https://github.com/rails/rails/pull/15747 but pulled to a
separate PR to reduce noise. `has_many :through` associations have the
undocumented behavior of automatically detecting counter caches.
However, the way in which it does so is inconsistent with counter caches
everywhere else, and doesn't actually work consistently.
As with normal `has_many` associations, the user should specify the
counter cache on the `belongs_to`, if they'd like it updated.
Diffstat (limited to 'activerecord/test/cases/associations/belongs_to_associations_test.rb')
| -rw-r--r-- | activerecord/test/cases/associations/belongs_to_associations_test.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/test/cases/associations/belongs_to_associations_test.rb b/activerecord/test/cases/associations/belongs_to_associations_test.rb index 9c92dc1141..d8d8bbf75e 100644 --- a/activerecord/test/cases/associations/belongs_to_associations_test.rb +++ b/activerecord/test/cases/associations/belongs_to_associations_test.rb @@ -787,8 +787,8 @@ class BelongsToAssociationsTest < ActiveRecord::TestCase post = posts(:welcome) comment = comments(:greetings) - assert_difference lambda { post.reload.taggings_count }, -1 do - assert_difference 'comment.reload.taggings_count', +1 do + assert_difference lambda { post.reload.tags_count }, -1 do + assert_difference 'comment.reload.tags_count', +1 do tagging.taggable = comment end end |