diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2019-03-18 03:09:00 +0900 |
---|---|---|
committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-03-18 03:57:16 +0900 |
commit | 187870db2fcc58aa0da8bb3f26711664fd5ed611 (patch) | |
tree | 9a6ee6843120b0a27948dc0f429004af70877729 /activerecord/test/cases/arel/insert_manager_test.rb | |
parent | 98e380f02452ee2597d122c76fd6b3a802f73333 (diff) | |
download | rails-187870db2fcc58aa0da8bb3f26711664fd5ed611.tar.gz rails-187870db2fcc58aa0da8bb3f26711664fd5ed611.tar.bz2 rails-187870db2fcc58aa0da8bb3f26711664fd5ed611.zip |
Get rid of `Arel::Nodes::Values`
That is completely covered by `Arel::Nodes::ValuesList`.
Related https://github.com/rails/arel/pull/484.
Diffstat (limited to 'activerecord/test/cases/arel/insert_manager_test.rb')
-rw-r--r-- | activerecord/test/cases/arel/insert_manager_test.rb | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/activerecord/test/cases/arel/insert_manager_test.rb b/activerecord/test/cases/arel/insert_manager_test.rb index 2376ad8d37..79b85742ee 100644 --- a/activerecord/test/cases/arel/insert_manager_test.rb +++ b/activerecord/test/cases/arel/insert_manager_test.rb @@ -11,19 +11,18 @@ module Arel end describe "insert" do - it "can create a Values node" do + it "can create a ValuesList node" do manager = Arel::InsertManager.new - values = manager.create_values %w{ a b }, %w{ c d } + values = manager.create_values_list([%w{ a b }, %w{ c d }]) - assert_kind_of Arel::Nodes::Values, values - assert_equal %w{ a b }, values.left - assert_equal %w{ c d }, values.right + assert_kind_of Arel::Nodes::ValuesList, values + assert_equal [%w{ a b }, %w{ c d }], values.rows end it "allows sql literals" do manager = Arel::InsertManager.new manager.into Table.new(:users) - manager.values = manager.create_values [Arel.sql("*")], %w{ a } + manager.values = manager.create_values([Arel.sql("*")]) manager.to_sql.must_be_like %{ INSERT INTO \"users\" VALUES (*) } @@ -186,9 +185,9 @@ module Arel manager = Arel::InsertManager.new manager.into table - manager.values = Nodes::Values.new [1] + manager.values = Nodes::ValuesList.new([[1], [2]]) manager.to_sql.must_be_like %{ - INSERT INTO "users" VALUES (1) + INSERT INTO "users" VALUES (1), (2) } end @@ -210,11 +209,11 @@ module Arel manager = Arel::InsertManager.new manager.into table - manager.values = Nodes::Values.new [1, "aaron"] + manager.values = Nodes::ValuesList.new([[1, "aaron"], [2, "david"]]) manager.columns << table[:id] manager.columns << table[:name] manager.to_sql.must_be_like %{ - INSERT INTO "users" ("id", "name") VALUES (1, 'aaron') + INSERT INTO "users" ("id", "name") VALUES (1, 'aaron'), (2, 'david') } end end |