aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/arel/delete_manager_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2019-04-01 15:04:11 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-04-01 15:04:11 +0900
commit6e43a207c6d3072d10b494d605b7bb6635043e30 (patch)
treeb2c0ac655273cb2fedc556f62e8f902ed1e0d15c /activerecord/test/cases/arel/delete_manager_test.rb
parent43866b2ca338375b964b0b905ee20f74f9b21b22 (diff)
downloadrails-6e43a207c6d3072d10b494d605b7bb6635043e30.tar.gz
rails-6e43a207c6d3072d10b494d605b7bb6635043e30.tar.bz2
rails-6e43a207c6d3072d10b494d605b7bb6635043e30.zip
Revert unused code and re-using query annotation for `update_all` and `delete_all`
This partly reverts #35617. #35617 includes unused code (for `InsertStatement`) and re-using query annotation for `update_all` and `delete_all`, which has not been discussed yet. If a relation has any annotation, I think it is mostly for SELECT query, so re-using annotation by default is not always desired behavior for me. We should discuss about desired behavior before publishing the implementation.
Diffstat (limited to 'activerecord/test/cases/arel/delete_manager_test.rb')
-rw-r--r--activerecord/test/cases/arel/delete_manager_test.rb18
1 files changed, 0 insertions, 18 deletions
diff --git a/activerecord/test/cases/arel/delete_manager_test.rb b/activerecord/test/cases/arel/delete_manager_test.rb
index 63cd1bffe3..0bad02f4d2 100644
--- a/activerecord/test/cases/arel/delete_manager_test.rb
+++ b/activerecord/test/cases/arel/delete_manager_test.rb
@@ -49,23 +49,5 @@ module Arel
dm.where(table[:id].eq(10)).must_equal dm
end
end
-
- describe "comment" do
- it "chains" do
- manager = Arel::DeleteManager.new
- manager.comment("deleting").must_equal manager
- end
-
- it "appends a comment to the generated query" do
- table = Table.new(:users)
- dm = Arel::DeleteManager.new
- dm.from table
- dm.comment("deletion")
- assert_match(%r{DELETE FROM "users" /\* deletion \*/}, dm.to_sql)
-
- dm.comment("deletion", "with", "comment")
- assert_match(%r{DELETE FROM "users" /\* deletion \*/ /\* with \*/ /\* comment \*/}, dm.to_sql)
- end
- end
end
end