diff options
author | Eileen Uchitelle <eileencodes@gmail.com> | 2018-12-05 15:36:29 -0500 |
---|---|---|
committer | Eileen Uchitelle <eileencodes@gmail.com> | 2018-12-07 08:53:47 -0500 |
commit | db54afba2e86ec9e45a8feb6e3ed325c99e7c5ed (patch) | |
tree | a41277a318319b5ca5cd2e9b33315ba5699dbfea /activerecord/test/cases/adapters/postgresql | |
parent | d9816546494f66e76bd5012a91b872dc2096a06c (diff) | |
download | rails-db54afba2e86ec9e45a8feb6e3ed325c99e7c5ed.tar.gz rails-db54afba2e86ec9e45a8feb6e3ed325c99e7c5ed.tar.bz2 rails-db54afba2e86ec9e45a8feb6e3ed325c99e7c5ed.zip |
Rename error that occurs when writing on a read
I originally named this `StatementInvalid` because that's what we do in
GitHub, but `@tenderlove` pointed out that this means apps can't test
for or explitly rescue this error. `StatementInvalid` is pretty broad so
I've renamed this to `ReadOnlyError`.
Diffstat (limited to 'activerecord/test/cases/adapters/postgresql')
-rw-r--r-- | activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb b/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb index 59ddb8457e..34b4fc344b 100644 --- a/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb +++ b/activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb @@ -378,7 +378,7 @@ module ActiveRecord def test_errors_when_an_insert_query_is_called_while_preventing_writes with_example_table do - assert_raises(ActiveRecord::StatementInvalid) do + assert_raises(ActiveRecord::ReadOnlyError) do @connection.while_preventing_writes do @connection.execute("INSERT INTO ex (data) VALUES ('138853948594')") end @@ -390,7 +390,7 @@ module ActiveRecord with_example_table do @connection.execute("INSERT INTO ex (data) VALUES ('138853948594')") - assert_raises(ActiveRecord::StatementInvalid) do + assert_raises(ActiveRecord::ReadOnlyError) do @connection.while_preventing_writes do @connection.execute("UPDATE ex SET data = '9989' WHERE data = '138853948594'") end @@ -402,7 +402,7 @@ module ActiveRecord with_example_table do @connection.execute("INSERT INTO ex (data) VALUES ('138853948594')") - assert_raises(ActiveRecord::StatementInvalid) do + assert_raises(ActiveRecord::ReadOnlyError) do @connection.while_preventing_writes do @connection.execute("DELETE FROM ex where data = '138853948594'") end |