diff options
author | Sean Griffin <sean@thoughtbot.com> | 2014-06-07 13:46:22 -0600 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2014-06-13 10:20:54 -0600 |
commit | 6f08db05c00ea05c38d7d9d7bea757a903786a83 (patch) | |
tree | bdf051f4286c280d7c724ae05f18692078e1524e /activerecord/test/cases/adapters/postgresql | |
parent | 70b931f846cb212f3db16f35a10094fb727a57e2 (diff) | |
download | rails-6f08db05c00ea05c38d7d9d7bea757a903786a83.tar.gz rails-6f08db05c00ea05c38d7d9d7bea757a903786a83.tar.bz2 rails-6f08db05c00ea05c38d7d9d7bea757a903786a83.zip |
Introduce an Attribute object to handle the type casting dance
There's a lot more that can be moved to these, but this felt like a good
place to introduce the object. Plans are:
- Remove all knowledge of type casting from the columns, beyond a
reference to the cast_type
- Move type_cast_for_database to these objects
- Potentially make them mutable, introduce a state machine, and have
dirty checking handled here as well
- Move `attribute`, `decorate_attribute`, and anything else that
modifies types to mess with this object, not the columns hash
- Introduce a collection object to manage these, reduce allocations, and
not require serializing the types
Diffstat (limited to 'activerecord/test/cases/adapters/postgresql')
-rw-r--r-- | activerecord/test/cases/adapters/postgresql/composite_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/test/cases/adapters/postgresql/composite_test.rb b/activerecord/test/cases/adapters/postgresql/composite_test.rb index 0b48fe9af8..42c68cdae7 100644 --- a/activerecord/test/cases/adapters/postgresql/composite_test.rb +++ b/activerecord/test/cases/adapters/postgresql/composite_test.rb @@ -84,7 +84,7 @@ class PostgresqlCompositeWithCustomOIDTest < ActiveRecord::TestCase class FullAddressType < ActiveRecord::Type::Value def type; :full_address end - def type_cast(value) + def type_cast_from_database(value) if value =~ /\("?([^",]*)"?,"?([^",]*)"?\)/ FullAddress.new($1, $2) end |