Rename error that occurs when writing on a read

I originally named this `StatementInvalid` because that's what we do in
GitHub, but `@tenderlove` pointed out that this means apps can't test
for or explitly rescue this error. `StatementInvalid` is pretty broad so
I've renamed this to `ReadOnlyError`.

1 files changed, 4 insertions, 4 deletions

diff --git a/activerecord/test/cases/adapters/mysql2/mysql2_adapter_test.rb b/activerecord/test/cases/adapters/mysql2/mysql2_adapter_test.rb
index bddcd309cd..7bc86476b6 100644
--- a/activerecord/test/cases/adapters/mysql2/mysql2_adapter_test.rb
+++ b/activerecord/test/cases/adapters/mysql2/mysql2_adapter_test.rb
@@ -70,7 +70,7 @@ class Mysql2AdapterTest < ActiveRecord::Mysql2TestCase
   end
 
   def test_errors_when_an_insert_query_is_called_while_preventing_writes
-    assert_raises(ActiveRecord::StatementInvalid) do
+    assert_raises(ActiveRecord::ReadOnlyError) do
       @conn.while_preventing_writes do
         @conn.insert("INSERT INTO `engines` (`car_id`) VALUES ('138853948594')")
       end
@@ -80,7 +80,7 @@ class Mysql2AdapterTest < ActiveRecord::Mysql2TestCase
   def test_errors_when_an_update_query_is_called_while_preventing_writes
     @conn.insert("INSERT INTO `engines` (`car_id`) VALUES ('138853948594')")
 
-    assert_raises(ActiveRecord::StatementInvalid) do
+    assert_raises(ActiveRecord::ReadOnlyError) do
       @conn.while_preventing_writes do
         @conn.update("UPDATE `engines` SET `engines`.`car_id` = '9989' WHERE `engines`.`car_id` = '138853948594'")
       end
@@ -90,7 +90,7 @@ class Mysql2AdapterTest < ActiveRecord::Mysql2TestCase
   def test_errors_when_a_delete_query_is_called_while_preventing_writes
     @conn.execute("INSERT INTO `engines` (`car_id`) VALUES ('138853948594')")
 
-    assert_raises(ActiveRecord::StatementInvalid) do
+    assert_raises(ActiveRecord::ReadOnlyError) do
       @conn.while_preventing_writes do
         @conn.execute("DELETE FROM `engines` where `engines`.`car_id` = '138853948594'")
       end
@@ -100,7 +100,7 @@ class Mysql2AdapterTest < ActiveRecord::Mysql2TestCase
   def test_errors_when_a_replace_query_is_called_while_preventing_writes
     @conn.execute("INSERT INTO `engines` (`car_id`) VALUES ('138853948594')")
 
-    assert_raises(ActiveRecord::StatementInvalid) do
+    assert_raises(ActiveRecord::ReadOnlyError) do
       @conn.while_preventing_writes do
         @conn.execute("REPLACE INTO `engines` SET `engines`.`car_id` = '249823948'")
       end