aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/adapters/mysql2/connection_test.rb
diff options
context:
space:
mode:
authorPrathamesh Sonpatki <csonpatki@gmail.com>2016-10-23 21:17:31 +0530
committerPrathamesh Sonpatki <csonpatki@gmail.com>2016-10-23 21:17:31 +0530
commitc5a4d007b8147c2f042844ac267821afa378d8e5 (patch)
tree989aa5803db97c6d942a52fb6ddb2be64beb2054 /activerecord/test/cases/adapters/mysql2/connection_test.rb
parent0fdeb0763621f500970fa3012bd8425fb5a81b63 (diff)
downloadrails-c5a4d007b8147c2f042844ac267821afa378d8e5.tar.gz
rails-c5a4d007b8147c2f042844ac267821afa378d8e5.tar.bz2
rails-c5a4d007b8147c2f042844ac267821afa378d8e5.zip
Fix brittle tests which were relying on the error message text from mysql2 gem
- These tests were fixed earlier on master in https://github.com/rails/rails/commit/f13ec72664fd13d33d617103ca964a7592295854. - They started failing in first place due to change in https://github.com/brianmario/mysql2/commit/f14023fcfee9e85e6fc1b0e568048811518f8c23. - They will fail again when the message is changed in mysql2 so let's not rely on the error message.
Diffstat (limited to 'activerecord/test/cases/adapters/mysql2/connection_test.rb')
-rw-r--r--activerecord/test/cases/adapters/mysql2/connection_test.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/activerecord/test/cases/adapters/mysql2/connection_test.rb b/activerecord/test/cases/adapters/mysql2/connection_test.rb
index b441ce3a34..ff012efc5f 100644
--- a/activerecord/test/cases/adapters/mysql2/connection_test.rb
+++ b/activerecord/test/cases/adapters/mysql2/connection_test.rb
@@ -65,18 +65,18 @@ class Mysql2ConnectionTest < ActiveRecord::Mysql2TestCase
def test_execute_after_disconnect
@connection.disconnect!
- error = assert_raise(ActiveRecord::StatementInvalid) do
+
+ assert_raise(ActiveRecord::StatementInvalid) do
@connection.execute("SELECT 1")
end
- assert_match(/MySQL client is not connected/, error.message)
end
def test_quote_after_disconnect
@connection.disconnect!
- error = assert_raise(Mysql2::Error) do
+
+ assert_raise(Mysql2::Error) do
@connection.quote("string")
end
- assert_match(/MySQL client is not connected/, error.message)
end
def test_active_after_disconnect