diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-11-08 13:57:51 -0200 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-11-08 13:59:07 -0200 |
commit | bd09afb5fb3e2047c605660dac6ef4495c419716 (patch) | |
tree | 205df2ab04d92e8093c341e132726325e9c40656 /activerecord/test/cases/adapter_test.rb | |
parent | 3d5e83fea4cc070fc55da535b7777a914301e284 (diff) | |
download | rails-bd09afb5fb3e2047c605660dac6ef4495c419716.tar.gz rails-bd09afb5fb3e2047c605660dac6ef4495c419716.tar.bz2 rails-bd09afb5fb3e2047c605660dac6ef4495c419716.zip |
Don't skip tests if we don't need to.
We can conditional define the tests depending on the adapter or
connection.
Lets keep the skip for fail tests that need to be fixed.
Diffstat (limited to 'activerecord/test/cases/adapter_test.rb')
-rw-r--r-- | activerecord/test/cases/adapter_test.rb | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/activerecord/test/cases/adapter_test.rb b/activerecord/test/cases/adapter_test.rb index dd355e8d0c..595edc6263 100644 --- a/activerecord/test/cases/adapter_test.rb +++ b/activerecord/test/cases/adapter_test.rb @@ -195,22 +195,20 @@ module ActiveRecord Klass.remove_connection end - test "transaction state is reset after a reconnect" do - skip "in-memory db doesn't allow reconnect" if in_memory_db? - - @connection.begin_transaction - assert @connection.transaction_open? - @connection.reconnect! - assert !@connection.transaction_open? - end - - test "transaction state is reset after a disconnect" do - skip "in-memory db doesn't allow disconnect" if in_memory_db? + unless in_memory_db? + test "transaction state is reset after a reconnect" do + @connection.begin_transaction + assert @connection.transaction_open? + @connection.reconnect! + assert !@connection.transaction_open? + end - @connection.begin_transaction - assert @connection.transaction_open? - @connection.disconnect! - assert !@connection.transaction_open? + test "transaction state is reset after a disconnect" do + @connection.begin_transaction + assert @connection.transaction_open? + @connection.disconnect! + assert !@connection.transaction_open? + end end end end |