aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/.gitignore
diff options
context:
space:
mode:
authorschneems <richard.schneeman@gmail.com>2017-02-23 16:22:50 -0600
committerschneems <richard.schneeman@gmail.com>2017-02-24 10:00:29 -0600
commit6ac4dabbcfa092ddda24ae9ee4698a55eb495021 (patch)
tree6cd429a5ecbb1fec83a23eba746c36172024729b /activerecord/test/.gitignore
parentc62f0f147830efe1ae6258be308d3c592d2f2350 (diff)
downloadrails-6ac4dabbcfa092ddda24ae9ee4698a55eb495021.tar.gz
rails-6ac4dabbcfa092ddda24ae9ee4698a55eb495021.tar.bz2
rails-6ac4dabbcfa092ddda24ae9ee4698a55eb495021.zip
[close #24435] Send user_supplied_options to server
Currently when Puma gets a `:Port` it doesn't know if it is Rails' default port or if it is one that is specified by a user. Because of this it assumes that the port passed in is always a user defined port and therefor 3000 always "wins" even if you specify `port` inside of the `config/puma.rb` file when booting your server with `rails s`. The fix is to record the options that are explicitly passed in from the user and pass those to the Puma server (or all servers really). Puma then has enough information to know when `:Port` is the default and when it is user defined. I went ahead and did this for all values rails server exposes as server side options for completeness. The hardest thing was converting the input say `-p` or `--port` into the appropriate "name", in this case `Port`. There may be a more straightforward way to do this with Thor, but I'm not an expert here. Move logic for parsing user options to method Better variable name for iteration Explicitly test `--port` user input ✂️ Update array if environment variables are used
Diffstat (limited to 'activerecord/test/.gitignore')
0 files changed, 0 insertions, 0 deletions