aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2013-07-06 08:18:17 -0700
committerRafael Mendonça França <rafaelmfranca@gmail.com>2013-07-06 08:18:17 -0700
commitebabdfbc2cf6629ef02205cf5047c9b30f76f49c (patch)
treeccadc9859bfe72dd86c7173c5a31484ae440bf77 /activerecord/lib
parent09965710dc7058abd2da3af1a27d7b72de009be6 (diff)
parente7e28a71be68271c7892477c1b9336316a1871bc (diff)
downloadrails-ebabdfbc2cf6629ef02205cf5047c9b30f76f49c.tar.gz
rails-ebabdfbc2cf6629ef02205cf5047c9b30f76f49c.tar.bz2
rails-ebabdfbc2cf6629ef02205cf5047c9b30f76f49c.zip
Merge pull request #11329 from vipulnsward/cache_one
Extract common query to a constant.
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/relation/finder_methods.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
index bad5886cde..9186b33bd2 100644
--- a/activerecord/lib/active_record/relation/finder_methods.rb
+++ b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -1,5 +1,7 @@
module ActiveRecord
module FinderMethods
+ ONE_AS_ONE = '1 AS one'
+
# Find by id - This can either be a specific id (1), a list of ids (1, 5, 6), or an array of ids ([5, 6, 10]).
# If no record can be found for all of the listed ids, then RecordNotFound will be raised. If the primary key
# is an integer, find by id coerces its arguments using +to_i+.
@@ -202,7 +204,7 @@ module ActiveRecord
relation = construct_relation_for_association_find(construct_join_dependency)
return false if ActiveRecord::NullRelation === relation
- relation = relation.except(:select, :order).select("1 AS one").limit(1)
+ relation = relation.except(:select, :order).select(ONE_AS_ONE).limit(1)
case conditions
when Array, Hash