diff options
| author | Sean Griffin <sean@seantheprogrammer.com> | 2015-12-14 08:18:05 -0700 |
|---|---|---|
| committer | David Heinemeier Hansson <david@loudthinking.com> | 2015-12-15 10:15:24 +0100 |
| commit | e12c2a6d11a9ebc28b85f34230b11fb654503726 (patch) | |
| tree | e7a792b82df69d11e41b7c7db46c21edcfc68c8e /activerecord/lib | |
| parent | 0aae9c25ab4d8d0a45e4353da4544b606b7b6584 (diff) | |
| download | rails-e12c2a6d11a9ebc28b85f34230b11fb654503726.tar.gz rails-e12c2a6d11a9ebc28b85f34230b11fb654503726.tar.bz2 rails-e12c2a6d11a9ebc28b85f34230b11fb654503726.zip | |
Deprecate limit strings with commas
Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`.
Supporting this in Active Record massively complicates using bind
parameters for limit and offset, and it's trivially easy to build an
invalid SQL query by also calling `offset` on the same `Relation`.
This is a niche syntax that is only supported by a few adapters, and can
be trivially worked around by calling offset explicitly.
Diffstat (limited to 'activerecord/lib')
| -rw-r--r-- | activerecord/lib/active_record/relation/query_methods.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index dbecb842b5..f7115c7a91 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -677,6 +677,12 @@ module ActiveRecord end def limit!(value) # :nodoc: + if ::String === value && value.include?(",") + ActiveSupport::Deprecation.warn(<<-WARNING) + Passing a string to limit in the form "1,2" is deprecated and will be + removed in Rails 5.1. Please call `offset` explicitly instead. + WARNING + end self.limit_value = value self end |