diff options
author | Jon Leighton <j@jonathanleighton.com> | 2012-04-13 19:06:35 +0100 |
---|---|---|
committer | Jon Leighton <j@jonathanleighton.com> | 2012-04-13 19:06:35 +0100 |
commit | d961f490ff1624b7c24a69d546a613768906f05c (patch) | |
tree | 4946834859b97889a70a987b6c7527cfcaf3326e /activerecord/lib | |
parent | 1ad138cf4b5c164c830917e5d4ef25943373bd0b (diff) | |
download | rails-d961f490ff1624b7c24a69d546a613768906f05c.tar.gz rails-d961f490ff1624b7c24a69d546a613768906f05c.tar.bz2 rails-d961f490ff1624b7c24a69d546a613768906f05c.zip |
move code out to active_record_deprecated_finders
Diffstat (limited to 'activerecord/lib')
-rw-r--r-- | activerecord/lib/active_record/relation/batches.rb | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/activerecord/lib/active_record/relation/batches.rb b/activerecord/lib/active_record/relation/batches.rb index 2fd89882ff..15f838a5ab 100644 --- a/activerecord/lib/active_record/relation/batches.rb +++ b/activerecord/lib/active_record/relation/batches.rb @@ -46,19 +46,14 @@ module ActiveRecord # group.each { |person| person.party_all_night! } # end def find_in_batches(options = {}) + options.assert_valid_keys(:start, :batch_size) + relation = self unless arel.orders.blank? && arel.taken.blank? ActiveRecord::Base.logger.warn("Scoped order and limit are ignored, it's forced to be batch order and batch size") end - if (finder_options = options.except(:start, :batch_size)).present? - raise "You can't specify an order, it's forced to be #{batch_order}" if options[:order].present? - raise "You can't specify a limit, it's forced to be the batch_size" if options[:limit].present? - - relation = apply_finder_options(finder_options) - end - start = options.delete(:start).to_i batch_size = options.delete(:batch_size) || 1000 |