diff options
| author | Aaron Patterson <aaron.patterson@gmail.com> | 2014-03-13 11:40:35 -0700 |
|---|---|---|
| committer | Aaron Patterson <aaron.patterson@gmail.com> | 2014-03-13 11:40:35 -0700 |
| commit | d92ae6ccca3bcfd73546d612efaea011270bd270 (patch) | |
| tree | 5eaf6b2449f29cc6050e802e1ca1491f7eb13537 /activerecord/lib | |
| parent | e88da370f190cabd1e9750c5b3531735950ab415 (diff) | |
| download | rails-d92ae6ccca3bcfd73546d612efaea011270bd270.tar.gz rails-d92ae6ccca3bcfd73546d612efaea011270bd270.tar.bz2 rails-d92ae6ccca3bcfd73546d612efaea011270bd270.zip | |
passing an ActiveRecord object to `exists?` is deprecated.
Pass the id of the object to the method by calling `.id` on the AR
object.
Diffstat (limited to 'activerecord/lib')
| -rw-r--r-- | activerecord/lib/active_record/associations/collection_association.rb | 2 | ||||
| -rw-r--r-- | activerecord/lib/active_record/relation/finder_methods.rb | 9 |
2 files changed, 9 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/associations/collection_association.rb b/activerecord/lib/active_record/associations/collection_association.rb index 9a2900843e..ff0fbe932b 100644 --- a/activerecord/lib/active_record/associations/collection_association.rb +++ b/activerecord/lib/active_record/associations/collection_association.rb @@ -370,7 +370,7 @@ module ActiveRecord if record.new_record? include_in_memory?(record) else - loaded? ? target.include?(record) : scope.exists?(record) + loaded? ? target.include?(record) : scope.exists?(record.id) end else false diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb index 1ba7fc47c0..180bc64e3a 100644 --- a/activerecord/lib/active_record/relation/finder_methods.rb +++ b/activerecord/lib/active_record/relation/finder_methods.rb @@ -1,3 +1,5 @@ +require 'active_support/deprecation' + module ActiveRecord module FinderMethods ONE_AS_ONE = '1 AS one' @@ -280,7 +282,12 @@ module ActiveRecord # Person.exists?(false) # Person.exists? def exists?(conditions = :none) - conditions = conditions.id if Base === conditions + if Base === conditions + conditions = conditions.id + ActiveSupport::Deprecation.warn "You are passing an instance of ActiveRecord::Base to `exists?`." \ + "Please pass the id of the object by calling `.id`" + end + return false if !conditions relation = apply_join_dependency(self, construct_join_dependency) |