aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authoryui-knk <spiketeika@gmail.com>2016-03-24 20:03:43 +0900
committeryui-knk <spiketeika@gmail.com>2016-03-24 20:45:23 +0900
commitcf570d7d0153283d2175b7330270d94291884864 (patch)
tree2ff43614ead7e934d4bb9e96b9c1da69cbf8012d /activerecord/lib
parent878c2bbaaf21f88543e75d4a986652d128ea8448 (diff)
downloadrails-cf570d7d0153283d2175b7330270d94291884864.tar.gz
rails-cf570d7d0153283d2175b7330270d94291884864.tar.bz2
rails-cf570d7d0153283d2175b7330270d94291884864.zip
Change for `ActiveRecord::Migration.[]` to raise `ArgumentError` instead of `RuntimeError`
The error is raised because user passed invalid version number to a public api of `ActiveRecord`, so `ArgumentError` is more suitable. And add a test case checking if an error is raised when unknown migration version is passed, because these test cases are not implemented.
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/migration.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/migration.rb b/activerecord/lib/active_record/migration.rb
index 4419a7b1e7..245c05f3e0 100644
--- a/activerecord/lib/active_record/migration.rb
+++ b/activerecord/lib/active_record/migration.rb
@@ -528,7 +528,7 @@ module ActiveRecord
name = "V#{version.tr('.', '_')}"
unless Compatibility.const_defined?(name)
versions = Compatibility.constants.grep(/\AV[0-9_]+\z/).map { |s| s.to_s.delete('V').tr('_', '.').inspect }
- raise "Unknown migration version #{version.inspect}; expected one of #{versions.sort.join(', ')}"
+ raise ArgumentError, "Unknown migration version #{version.inspect}; expected one of #{versions.sort.join(', ')}"
end
Compatibility.const_get(name)
end