diff options
| author | James Le Cuirot <james.le-cuirot@yakara.com> | 2015-03-18 15:15:05 +0000 |
|---|---|---|
| committer | James Le Cuirot <james.le-cuirot@yakara.com> | 2018-10-29 15:11:35 +0000 |
| commit | cf1d75d95d06ce3ac9e3ab7f19ecc17b49530942 (patch) | |
| tree | fdb7c6f84f92f5f90bf346447ea5d5dce277e466 /activerecord/lib | |
| parent | 0d68e0690f449bf815c975c25d4d74917d3cad11 (diff) | |
| download | rails-cf1d75d95d06ce3ac9e3ab7f19ecc17b49530942.tar.gz rails-cf1d75d95d06ce3ac9e3ab7f19ecc17b49530942.tar.bz2 rails-cf1d75d95d06ce3ac9e3ab7f19ecc17b49530942.zip | |
Avoid violating key constraints in fixture HABTM associations
When loading fixtures, Ruby 1.9's hash key ordering means that HABTM
join table rows are always loaded before the parent table rows,
violating foreign key constraints that may be in place. This very
simple change ensures that the parent table's key appears first in the
hash. Violations may still occur if fixtures are loaded in the wrong
order but those instances can be avoided unlike this one.
Diffstat (limited to 'activerecord/lib')
| -rw-r--r-- | activerecord/lib/active_record/fixture_set/table_rows.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/activerecord/lib/active_record/fixture_set/table_rows.rb b/activerecord/lib/active_record/fixture_set/table_rows.rb index e8335a2e10..3e3c0bc7ab 100644 --- a/activerecord/lib/active_record/fixture_set/table_rows.rb +++ b/activerecord/lib/active_record/fixture_set/table_rows.rb @@ -45,6 +45,9 @@ module ActiveRecord # track any join tables we need to insert later @tables = Hash.new { |h, table| h[table] = [] } + # ensure this table is loaded before any HABTM associations + @tables[table_name] = nil + build_table_rows_from(fixtures, config) end |