diff options
author | Aaron Patterson <aaron.patterson@gmail.com> | 2011-01-04 15:08:28 -0800 |
---|---|---|
committer | Aaron Patterson <aaron.patterson@gmail.com> | 2011-01-04 15:08:28 -0800 |
commit | c08fccf980745d30c60943f1440a81538a997f53 (patch) | |
tree | 7a86d32037968075c6214619e6346a36bf1210f0 /activerecord/lib | |
parent | 4fabad7cf125178c95468a573951e587928c333b (diff) | |
parent | 9c1c551f25577c01624b23bc53139c60a4fc451b (diff) | |
download | rails-c08fccf980745d30c60943f1440a81538a997f53.tar.gz rails-c08fccf980745d30c60943f1440a81538a997f53.tar.bz2 rails-c08fccf980745d30c60943f1440a81538a997f53.zip |
Merge remote branch 'rsim/habtm_select_fix'
* rsim/habtm_select_fix:
Explicitly select * from has_and_belongs_to_many association tables, simplify exists? query
Diffstat (limited to 'activerecord/lib')
-rw-r--r-- | activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb | 3 | ||||
-rw-r--r-- | activerecord/lib/active_record/relation/finder_methods.rb | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb b/activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb index 1c237eda33..a4194defc2 100644 --- a/activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb +++ b/activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb @@ -83,7 +83,8 @@ module ActiveRecord super.merge( :joins => construct_joins, :readonly => ambiguous_select?(@reflection.options[:select]), - :select => @reflection.options[:select] || Arel.star + :select => @reflection.options[:select] || + Arel.sql("#{@reflection.quoted_table_name}.*, #{@owner.connection.quote_table_name @reflection.options[:join_table]}.*") ) end diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb index 13f55319a7..8bbc47ab75 100644 --- a/activerecord/lib/active_record/relation/finder_methods.rb +++ b/activerecord/lib/active_record/relation/finder_methods.rb @@ -171,7 +171,7 @@ module ActiveRecord def exists?(id = nil) id = id.id if ActiveRecord::Base === id - relation = select(table[primary_key]).limit(1) + relation = select("1").limit(1) case id when Array, Hash |