Merge pull request #27531 from kamipo/string_timestamp_attributes

Change `timestamp_attributes_for_{create,update}` from symbol to string

1 files changed, 5 insertions, 6 deletions

diff --git a/activerecord/lib/active_record/timestamp.rb b/activerecord/lib/active_record/timestamp.rb
index 63100e38a1..030fc35e2f 100644
--- a/activerecord/lib/active_record/timestamp.rb
+++ b/activerecord/lib/active_record/timestamp.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ActiveRecord
   # = Active Record \Timestamp
   #
@@ -58,7 +59,6 @@ module ActiveRecord
         current_time = current_time_from_proper_timezone
 
         all_timestamp_attributes.each do |column|
-          column = column.to_s
           if has_attribute?(column) && !attribute_present?(column)
             write_attribute(column, current_time)
           end
@@ -73,7 +73,6 @@ module ActiveRecord
         current_time = current_time_from_proper_timezone
 
         timestamp_attributes_for_update_in_model.each do |column|
-          column = column.to_s
           next if will_save_change_to_attribute?(column)
           write_attribute(column, current_time)
         end
@@ -86,11 +85,11 @@ module ActiveRecord
     end
 
     def timestamp_attributes_for_create_in_model
-      timestamp_attributes_for_create.select { |c| self.class.column_names.include?(c.to_s) }
+      timestamp_attributes_for_create.select { |c| self.class.column_names.include?(c) }
     end
 
     def timestamp_attributes_for_update_in_model
-      timestamp_attributes_for_update.select { |c| self.class.column_names.include?(c.to_s) }
+      timestamp_attributes_for_update.select { |c| self.class.column_names.include?(c) }
     end
 
     def all_timestamp_attributes_in_model
@@ -98,11 +97,11 @@ module ActiveRecord
     end
 
     def timestamp_attributes_for_update
-      [:updated_at, :updated_on]
+      ["updated_at", "updated_on"]
     end
 
     def timestamp_attributes_for_create
-      [:created_at, :created_on]
+      ["created_at", "created_on"]
     end
 
     def all_timestamp_attributes