aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorbrainopia <brainopia@evilmartians.com>2015-01-07 03:29:26 +0300
committerbrainopia <brainopia@evilmartians.com>2015-01-08 01:42:33 +0300
commit824862807be47bee5adbd15e365a2add57df5301 (patch)
tree98bf41e7d60020a7564787fdf6e82f80e829772f /activerecord/lib
parent5d28c6b5b8407abf9274f78502d387c98f209286 (diff)
downloadrails-824862807be47bee5adbd15e365a2add57df5301.tar.gz
rails-824862807be47bee5adbd15e365a2add57df5301.tar.bz2
rails-824862807be47bee5adbd15e365a2add57df5301.zip
Fix count on a separate connection (fixes #18359)
Previosly count and other AR calculations would convert column_name_for_operation to sql on a default Arel::Table.engine (AR::Base) connection. That could lead to trouble if current model has a connection to a different adapter or Base connection is inaccessible.
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/connection_adapters/abstract_adapter.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
index c3a8bf5c74..e52b666296 100644
--- a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
+++ b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
@@ -392,7 +392,7 @@ module ActiveRecord
end
def column_name_for_operation(operation, node) # :nodoc:
- node.to_sql
+ visitor.accept(node, collector).value
end
protected