aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2018-10-27 22:45:29 +0900
committerGitHub <noreply@github.com>2018-10-27 22:45:29 +0900
commit6c98dad59d29bc26b4957d2b7547b16bc9919526 (patch)
tree8f4a03fda9b1c5e0b3825fd6abdb1e7bfd8789a0 /activerecord/lib
parent5431e17733366da1fd10f2cd3039d66a56012683 (diff)
parent4694fcf4133a74bb0689e4888e73aa2f605394f7 (diff)
downloadrails-6c98dad59d29bc26b4957d2b7547b16bc9919526.tar.gz
rails-6c98dad59d29bc26b4957d2b7547b16bc9919526.tar.bz2
rails-6c98dad59d29bc26b4957d2b7547b16bc9919526.zip
Merge pull request #34329 from r7kamura/feature/where-exclamation-consistency
Ignore empty condition on #construct_relation_for_exists
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/relation/finder_methods.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
index 6f420fe6bb..afaa900442 100644
--- a/activerecord/lib/active_record/relation/finder_methods.rb
+++ b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -363,7 +363,7 @@ module ActiveRecord
case conditions
when Array, Hash
- relation.where!(conditions)
+ relation.where!(conditions) unless conditions.empty?
else
relation.where!(primary_key => conditions) unless conditions == :none
end