aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorSantiago Pastorino <santiago@wyeworks.com>2015-08-25 12:19:20 -0300
committerSantiago Pastorino <santiago@wyeworks.com>2015-08-25 12:19:20 -0300
commit61ebc20cdfeb68cd7e6d2e698a5b20f8449131e6 (patch)
tree584bd07d262f4c1cb76d5a435c104e63d0f6f71b /activerecord/lib
parent57105d99bccadc7d48af199b73ac2d891a15f9da (diff)
parentc90008a86ee486334531d5096c04da5100ced692 (diff)
downloadrails-61ebc20cdfeb68cd7e6d2e698a5b20f8449131e6.tar.gz
rails-61ebc20cdfeb68cd7e6d2e698a5b20f8449131e6.tar.bz2
rails-61ebc20cdfeb68cd7e6d2e698a5b20f8449131e6.zip
Merge pull request #21372 from yui-knk/fix/revert_change_column_default
Make `change_column_default` to work
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/migration/command_recorder.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/activerecord/lib/active_record/migration/command_recorder.rb b/activerecord/lib/active_record/migration/command_recorder.rb
index dcc2362397..b52e89d792 100644
--- a/activerecord/lib/active_record/migration/command_recorder.rb
+++ b/activerecord/lib/active_record/migration/command_recorder.rb
@@ -14,6 +14,13 @@ module ActiveRecord
# * rename_index
# * rename_table
class CommandRecorder
+ ReversibleAndIrreversibleMethods = [:create_table, :create_join_table, :rename_table, :add_column, :remove_column,
+ :rename_index, :rename_column, :add_index, :remove_index, :add_timestamps, :remove_timestamps,
+ :change_column_default, :add_reference, :remove_reference, :transaction,
+ :drop_join_table, :drop_table, :execute_block, :enable_extension,
+ :change_column, :execute, :remove_columns, :change_column_null,
+ :add_foreign_key, :remove_foreign_key
+ ]
include JoinTable
attr_accessor :commands, :delegate, :reverting
@@ -70,14 +77,7 @@ module ActiveRecord
super || delegate.respond_to?(*args)
end
- [:create_table, :create_join_table, :rename_table, :add_column, :remove_column,
- :rename_index, :rename_column, :add_index, :remove_index, :add_timestamps, :remove_timestamps,
- :add_reference, :remove_reference, :transaction,
- :drop_join_table, :drop_table, :execute_block, :enable_extension,
- :change_column, :execute, :remove_columns, :change_column_null,
- :add_foreign_key, :remove_foreign_key
- # irreversible methods need to be here too
- ].each do |method|
+ ReversibleAndIrreversibleMethods.each do |method|
class_eval <<-EOV, __FILE__, __LINE__ + 1
def #{method}(*args, &block) # def create_table(*args, &block)
record(:"#{method}", args, &block) # record(:create_table, args, &block)